search

forcedotcom / commerce-on-lightning

An SFDX Plugin to setup a B2C or B2B Store
BSD 3-Clause "New" or "Revised" License
65 stars 71 forks source link

Switch to replaceAll #280

Closed avaHitesh-github closed 8 months ago

avaHitesh-github commented 8 months ago

Buyer User Email's replace '@' function requires replaceAll instead of replace.

What does this PR do?

Fixes the Buyer Email generation in the store create.ts command

What issues does this PR fix or reference?

279 https://github.com/forcedotcom/commerce-on-lightning/issues/279, @@

Functionality Before

replaces only the first instance of @ with AT

Functionality After

replaces all the instances of @ with AT

How to Test/Testing Effort

Create Scrach org and Create store:

sfdx commerce:scratchorg:create -u hitorg1@hit.demo -a "hitorg1" -v devhub -w 30 --json sfdx commerce:store:create -n b2cstore1 -o b2c -b b2cbuyer1@gmail.com -v devhub -u hitorg1

avaHitesh-github commented 8 months ago

@tarcang should I create a hotfix PR to the main branch for it to be released as a hotfix?

tarcang commented 8 months ago

Yes, please create a hotfix pr to the main branch.