forcedotcom / commerce-on-lightning

An SFDX Plugin to setup a B2C or B2B Store
BSD 3-Clause "New" or "Revised" License
64 stars 74 forks source link

@W-14700593 | Remove commit hook logic that bumps patch version after every commit #297

Closed tarcang closed 8 months ago

tarcang commented 9 months ago

What does this PR do?

Removes updating the patch version every time a commit happens. In the past, this allowed for confusions in release versioning.

What issues does this PR fix or reference?

@W-14700593@

Note: I have investigated how to get rid of the minor version bump after pushing to main but I have realized that would require a bigger change in onPushToMain workflow than I expected. In the inherited workflow, the input option for "skip-version-file" for the https://github.com/TriPSs/conventional-changelog-action/commits?author=TriPSs that is used in the workflow is not exposed. This means instead of inheriting from the oclif github workflows, we had to copy paste the whole file just to add the "skip-version-file: true" tag. Seemed to much change since it would add a lot of maintenance overhead.