Insert Step3 Mapping not resized properly

forcedotcom / dataloader

Salesforce Data Loader

BSD 3-Clause "New" or "Revised" License

474 stars 294 forks source link

Insert Step3 Mapping not resized properly #1049

Closed PawelWozniak closed 5 months ago

PawelWozniak commented 5 months ago

Describe the bug This is continuation of issue https://github.com/forcedotcom/dataloader/issues/1017

To Reproduce Steps to reproduce the behavior:

Open data loader and choose Insert
Navigate to Step 3 Mapping.
If you have more than 7 rows in your CSV file then the table is cut as it doesn't resize properly to available space.

Expected behavior Table is resized to take whole window space

Screenshots

Additional improvement could be made to Mapping Dialog which is not set by default the same size as other screens. This cause a need for more scrolling or manual screen resize.

Desktop (please complete the following information):

OS: Windows 11
Version 60.0.2 beta from task 1017

ashitsalesforce commented 5 months ago

Hi @PawelWozniak , here is a patch containing fix for the issue seen on Mapping page. Is the issue on Mapping dialog that the dialog width or height is too short, thereby requiring resizing or scrolling?

dataloader_v60.0.2.zip

MD5 (dataloader_v60.0.2.zip) = a5969b9bc7d51b1201ba3ec014426c89

PawelWozniak commented 5 months ago

Hi @ashitsalesforce In step 3 mapping it is now resized correctly to the bottom of the window but columns width are set too big causing horizontal scroll activation.

Yes I needed manually resize Mapping dialog or do scrolling. Now this windows is by default the same size as other windows causing less scrolling. Now is much better but it contains the same issue as on previous screen that columns are too wide.

If you will change how "CSV Column Header" and "Field Name/Relationship" width is set to expand just to main window width and no more the it will be perfect.

ashitsalesforce commented 5 months ago

@PawelWozniak , thanks for testing and identifying remaining minor issues. Here is a patch with the fix:

dataloader_v60.0.2.zip

MD5 (dataloader_v60.0.2.zip) = d3ff44f4e7ae28adbbda954ce424ece7

PawelWozniak commented 5 months ago

@ashitsalesforce now it looks perfect.

All that fixes makes Dataloader more user friendly, thank you.

ashitsalesforce commented 5 months ago

Thanks @PawelWozniak for your feedback in improving the UI.