search

forcedotcom / devops-center-feedback

61 stars 2 forks source link

Committing a page layout change results in a "Create Review Blocked" error #238

Open bnoffsinger opened 2 years ago

bnoffsinger commented 2 years ago

Describe the bug A work item which involved page layout changes to one layout (specifically removing some read only locks on fields in a layout) was committed successfully to the work item, but the top right corner where "Create Review" normally is is a "Create Review Blocked" error, which when clicked says: "You can't create a change request because the commit contains only deleted files that don't currently exist in the repository. To proceed, commit another change to this work item." This happened even when setting one work item to Never and trying again. I do see the commit in Github as well.

To Reproduce Steps to reproduce the behavior:

  1. Make the specified Layout changes
  2. commit only the Layout metadata element to the work item
  3. Try to Create Review

Expected behavior I should be able to move this item through to promotion as the metadata was committed successfully

Screenshots DevOpsBug

Additional context

jaapvandermolen commented 1 year ago

I have the same issue.

sdavis-AWP commented 1 year ago

I also have the same issue

sdavis-AWP commented 1 year ago

@bnoffsinger and @jaapvandermolen Can I ask, how did you proceed after this? Add additional changes to the WI?

sdavis-AWP commented 1 year ago

@bnoffsinger and @jaapvandermolen I think I found the source of this. I noticed in @bnoffsinger's screenshot the page layout had something in common with the ones I was trying to deploy as well. The layout name is "Account-1.6 Universal Provider Layout" which contains a "-" and ours contain a "&". Looking at the file name in GH after our commit I could see that the name was URL encoded and switched our special character with "%26". @bnoffsinger's is probably going to be "%2D" instead of the "-". Git should be able to handle these just fine so it's definitely being encoded by DevOps Center.

Anyway, as a workaround save a new layout with a name that doesn't contain any characters that will be encoded. You can test the name here: https://www.w3schools.com/tags/ref_urlencode.ASP

msteinercrmfirm commented 1 year ago

Man after spending about 7 hours troubleshooting, found this article and it was totally the problem for me. Trying to deploy a layout with special characters. Switched to a regular layout no issues.

catmac42 commented 9 months ago

I'm having a similar issue with an Email Template. The template name itself doesn't have any special characters, but it's in a folder, which makes the metadata item appear like this: folder name/template name (with a forward slash). Not sure how to get around this one.

jenniferhyphen8 commented 2 months ago

Also having the same issue as @catmac42, with an email template in a folder.