search

forcedotcom / git2gus

A Github application to keep issues in sync with Agile Accelerator
https://lwc-gus-bot.herokuapp.com
BSD 3-Clause "New" or "Revised" License
27 stars 16 forks source link

Fix duplicate work items created for non-Salesforce labels #105

Closed jessebrack closed 3 years ago

jessebrack commented 3 years ago

Resolves https://github.com/forcedotcom/git2gus/issues/97 where the createWorkItem action would fire off even for non-Salesforce labels. I added an early check to check to verify if the label added was a Salesforce label.

jessebrack commented 3 years ago

Sorry @jag-sfdc ! I did not see https://github.com/forcedotcom/git2gus/pull/102 until after I created this PR 🤦.

jag-j commented 3 years ago

@jessebrack - Thanks once again for your PRs. Yes! I'm taking care of this in the linked PR. It does a few more things like defaulting to GUS API usage over Salesforce Connect and the test updates as well. Is it ok if I close this PR?

reiniergs commented 3 years ago

@jag-sfdc can we close this PR then?

jessebrack commented 3 years ago

@jessebrack - Thanks once again for your PRs. Yes! I'm taking care of this in the linked PR. It does a few more things like defaulting to GUS API usage over Salesforce Connect and the test updates as well. Is it ok if I close this PR?

Of course! I'll close this PR out, thank you for the fixes.