search

forcedotcom / lightning-language-server

LWC and Aura Language Servers - shipped as part of the Salesforce VSCode Extensions
https://forcedotcom.github.io/salesforcedx-vscode/
BSD 3-Clause "New" or "Revised" License
31 stars 48 forks source link

fix(core): update core config file and handle read errors #558

Closed mpsenn closed 1 year ago

mpsenn commented 1 year ago

The core config file containing environment variables is now build/dev.properties. Use that file instead of config.blt. Additionally handle any errors in parsing and reading by logging to console and not attempting to write to the file.

Fixes @W-13007946@. Fixes #497.

mpsenn commented 1 year ago

Fixes #497.

mpsenn commented 1 year ago

Note: for git checkout of core, this generates settings with empty p4.port values, etc. This is fine, I think the eslint executable is what really matters.

mpsenn commented 1 year ago

@randi274 Apologies I should have tested myself! I've updated the change, after taking a closer look at a colleague's setup, it looks like env. variables are used for the config now instead of a properties file. So I've updated the implementation, and modified the test workspace to match.

randi274 commented 1 year ago

Thanks again @mpsenn! We'll get this updated in vs code ASAP 🎉