search

forcedotcom / lightning-language-server

LWC and Aura Language Servers - shipped as part of the Salesforce VSCode Extensions
https://forcedotcom.github.io/salesforcedx-vscode/
BSD 3-Clause "New" or "Revised" License
33 stars 49 forks source link

fix: do not write jsconfig.json on core when there is tsconfig.json #586

Closed rui-rayqiu closed 8 months ago

rui-rayqiu commented 8 months ago

What does this PR do?

Since we started to support TypeScript for LWC on core, we added tsconfig.json files on core's UI modules directory, e.g., ui-force-components/tsconfig.json. This tsconfig.json would conflict with jsconfig.json file that is automatically generated. This PR disable the generation of jsconfig.json file on core if there is an existing jsconfig.json file on core.

What issues does this PR fix or reference?

@W-14590716@

Functionality before

https://github.com/forcedotcom/lightning-language-server/assets/113132642/b6c4cd88-08fa-41ae-97ec-8577709598b8

Functionality after

https://github.com/forcedotcom/lightning-language-server/assets/113132642/89fae34f-c8db-42a4-a1f1-864d75bf040f

salesforce-cla[bot] commented 8 months ago

Thanks for the contribution! It looks like @rui-rayqiu is an internal user so signing the CLA is not required. However, we need to confirm this.