`mock-fs` is incompatible with Node v20 - Githubissues

forcedotcom / lightning-language-server

LWC and Aura Language Servers - shipped as part of the Salesforce VSCode Extensions

https://forcedotcom.github.io/salesforcedx-vscode/

BSD 3-Clause "New" or "Revised" License

31 stars 48 forks source link

`mock-fs` is incompatible with Node v20 #592

Open jmsjtu opened 3 days ago

jmsjtu commented 3 days ago

Summary

The mock-fs package is incompatible with Node v20, which causes unit tests in the aura-language-server and lightning-lsp-common to fail.

It looks like there's a draft PR in mock-fs to support Node v20 but progress seems to be slow.

A potential replacement is memfs, although there's some extra plumbing that needs to happen to make it compatible with existing tests.

Steps To Reproduce:

Install node v20
Run unit tests

Expected result

No test failures

Actual result

Test failures

jmsjtu commented 3 days ago

The fix introduced in #593 is a temporary work-around to unblock other PRs.