Add more unit tests for hash join scenarios - Githubissues

forcedotcom / phoenix

BSD 3-Clause "New" or "Revised" License

558 stars 227 forks source link

Add more unit tests for hash join scenarios #505

Open jtaylor-sfdc opened 11 years ago

jtaylor-sfdc commented 11 years ago

We have some good end-to-end tests for hash join, but we need more. In particular, for end2end tests:

where LHS and RHS are expressions, not just column references
where the LHS data type and RHS data type are different (i.e. INTEGER vs BIGINT)
with more pre/post condition scenarios

Lower level unit tests:

negative tests (see QueryCompilerTest)
compiler tests (see WhereClauseScanKeyTest and WhereClauseFilterTest as a guide)