search

forcedotcom / phoenix

BSD 3-Clause "New" or "Revised" License
558 stars 227 forks source link

Enable a minimal jar and a minimal client jar on calls to mvn package. #546

Closed jyates closed 10 years ago

jyates commented 10 years ago

This also does some cleanup of the build specs to reuse the dependencies in component descriptors. Means less duplication across the different assembly descriptors, and less chance for mistake

jtaylor-sfdc commented 10 years ago

Should we update the build.txt too?

jyates commented 10 years ago

Don't need to update build.txt - still works with just the package phase.

jtaylor-sfdc commented 10 years ago

How does one build the "minimal" jar versus the "client" jar, and where do you think it makes sense to document this?

jyates commented 10 years ago

they are all built when you run "mvn package", including the tarball. That was the behavior prior to this, so I just stuck with it. build.txt seems a reasonable place to document it.

jyates commented 10 years ago

I think this is the fix you guys requested.

rtvt123 commented 10 years ago

snappy dependency is missing on the clients, this is needed for JOINs

jyates commented 10 years ago

I think joins were added after this feature. Mind filling another issue if I'm wrong?

I'm on vacation till the end of the month (and away from an IDE), so James may have to handle this if it's pressing.

--Jesse Yates

Sent from my iPad

On Jan 3, 2014, at 6:30 AM, alexdl notifications@github.com wrote:

snappy dependency is missing on the clients, this is needed for JOINs

— Reply to this email directly or view it on GitHub.