search

forcedotcom / phoenix

BSD 3-Clause "New" or "Revised" License
558 stars 227 forks source link

Fix issue #642 NPE on Join over Salted table #651

Closed maryannxue closed 10 years ago

maryannxue commented 10 years ago

Also included

Bug fixes:

  1. Wrong calculation of number of Longs in ValueBitSet#toBytes().
  2. Redundant and mistaken calling to optimize() for join queries.

Join runtime code refactoring. Add interface Tuple#getValue(cf, cq, ptr) to avoid creating new KeyValues in joins. Skip-merge optimization for joins.

jtaylor-sfdc commented 10 years ago

Very nice, @maryannxue! Can I pull it in?

maryannxue commented 10 years ago

@jtaylor-sfdc Sure, please do.

jtaylor-sfdc commented 10 years ago

@maryannxue - would you mind adding some salted table tests to your HashJoinTest? You should be able to just have the LHS table be salted, the RHS table be salted, both tables salted and neither table salted. That would provide pretty good coverage.

maryannxue commented 10 years ago

@jtaylor-sfdc Sure.