forcedotcom / phoenix

BSD 3-Clause "New" or "Revised" License
558 stars 227 forks source link

In DeleteCompiler don't use context.isSingleRowScan() for optimizing delete #652

Closed jtaylor-sfdc closed 10 years ago

jtaylor-sfdc commented 10 years ago

Instead we should use ScanUtil.isAllSingleRowScan(cnf, table.getRowKeySchema()) as is done in WhereOptimizer, as this takes into account fully qualified statements with IN clauses.

As a result, fix MetaDataClient.dropColumnMutations() too, as we really should only need to execute a single IN query (which would be executed client-side once this is fixed).

jtaylor-sfdc commented 10 years ago

Fixed in master