search

forcedotcom / phoenix

BSD 3-Clause "New" or "Revised" License
558 stars 227 forks source link

ArrayLength function #675

Closed ramkrish86 closed 10 years ago

ramkrish86 commented 10 years ago

I have made changes to change the Vint for array elements to Integer. If I have the return type as VARBINARY for the vint still it is not able to decode the integer stored in a single byte. Now after changing it to Integer still for the ArrayLengthFunction am not able to use PDataType.INTEGER as the return type but using PDataType.VARBINARY works. This may not be the final version if you feel some changes on the above are required.

ramkrish86 commented 10 years ago

For I have commented out the changes for Vint and introduced Integer. Next pull I can change them.

jtaylor-sfdc commented 10 years ago

Looks good, @ramkrish86. Thanks for the excellent work!

ramkrish86 commented 10 years ago

Just was thinking that for the fixed length array we need not serialize the number of elements as we could just calculate from the buffer size. What do you feel?

jtaylor-sfdc commented 10 years ago

Yes, isn't that what you did? Or maybe you're serializing it but not using it?

On Thu, Jan 2, 2014 at 9:39 PM, ramkrish86 notifications@github.com wrote:

Just was thinking that for the fixed length array we need not serialize the number of elements as we could just calculate from the buffer size. What do you feel?

— Reply to this email directly or view it on GitHubhttps://github.com/forcedotcom/phoenix/pull/675#issuecomment-31506454 .

ramkrish86 commented 10 years ago

Yes. I am serializing it but not using it. I will give another request for removing that serialization also.