forcedotcom / phoenix

BSD 3-Clause "New" or "Revised" License
558 stars 227 forks source link

JDBC client connection properties #691

Closed jmlvanre closed 10 years ago

jmlvanre commented 10 years ago

A patch to enable properties to be passed through the JDBC client and attributed to the Phoenix Connection. This is regarding issue #338

I followed @jtaylor-sfdc instructions (https://groups.google.com/forum/#!topic/phoenix-hbase-user/mWLPltncOeY) using a DelegateConnectionQueryService and overriding the getProps() function.

yllierop commented 10 years ago

:+1: @jtaylor-sfdc what do you think?

jtaylor-sfdc commented 10 years ago

@jmlvanre - please take a look at my comments above. Thanks!

jmlvanre commented 10 years ago

@jtaylor-sfdc Does this look good?

jtaylor-sfdc commented 10 years ago

Looks great, @jmlvanre. Thanks for the contribution!

yllierop commented 10 years ago

:+1:

qmjava commented 10 years ago

Hmm, this fix doesn't appear to work. I tried passing a property object to pheonix with some overriden property, but has no effect. Is this changed incorporated into 3.0.0 release? Doesn't look like it.