search

forcedotcom / phoenix

BSD 3-Clause "New" or "Revised" License
558 stars 227 forks source link

Support UpsertValues #695

Closed ramkrish86 closed 10 years ago

ramkrish86 commented 10 years ago

I have made changes to support Upsert VALUES with ARRAY. This does not support Upsert with SELECT still. Wanted to know your opinion on this. If this path looks fine I can continue with that too.
May be I can handle Upsert SELECT as a seperate pull.

jtaylor-sfdc commented 10 years ago

@ramkrish86 - this is looking good, but there's more to do to generalize it. If you want, I can pull it in now and you can keep going with it back over at our new Apache home. Let me know.

ramkrish86 commented 10 years ago

Let me try to generalize this after analysing your comments. If the code is going to move to apache home very soon then I think better to pull this in and let me continue from there. Thanks James.

jtaylor-sfdc commented 10 years ago

I'll pull it in, but please make the above changes before starting on the UPSERT SELECT part of it, as your implementation will likely be different once you complete the UPSERT VALUES part of it.