search

forcedotcom / phoenix

BSD 3-Clause "New" or "Revised" License
559 stars 227 forks source link

Upsert Values and Upsert Select with Array #707

Closed ramkrish86 closed 10 years ago

ramkrish86 commented 10 years ago

This does not support Upsert Into a specific Array index because we are not currently reading before doing an update. So getting the index and updating an array index would not be simple enough.

jtaylor-sfdc commented 10 years ago

Can't seem to find ArrayConstructorExpression. Also, for consistency with other class names, please name ArrayConstructorNode ArrayConstructorParseNode.

Looks like this needs to be re-based too, as it's not letting me merge it.

Thanks in advance for the contributions!

ramkrish86 commented 10 years ago

Sorry.. I did not add the new classes.. Now pushed it again. Any way will address the review comments and give another push by EOD. Thanks for the review James.

From: James Taylor [mailto:notifications@github.com] Sent: Wednesday, January 22, 2014 2:20 PM To: forcedotcom/phoenix Cc: Vasudevan, Ramkrishna S Subject: Re: [phoenix] Upsert Values and Upsert Select with Array (#707)

Can't seem to find ArrayConstructorExpression. Also, for consistency with other class names, please name ArrayConstructorNode ArrayConstructorParseNode.

Looks like this needs to be re-based too, as it's not letting me merge it.

Thanks in advance for the contributions!

— Reply to this email directly or view it on GitHubhttps://github.com/forcedotcom/phoenix/pull/707#issuecomment-33002752.