Add pie chart - Githubissues

forcedotcom / quiz-host-app

Multiplayer quiz app built on Salesforce technology (host app)

Creative Commons Zero v1.0 Universal

108 stars 67 forks source link

Add pie chart #27

Closed annyhe closed 4 years ago

annyhe commented 4 years ago

side by side with scoreboard To test, create a player record, create answer record for the current question and the newly created player. The rendered scoreboard should show 0 for all the answers except for the answer the player picked.

pozil commented 4 years ago

Please switch to the minified version of Chart.js.

pozil commented 4 years ago

Make sure to run Prettier before committing your changes, I'm seeing some local changes in the current state of the project.

annyhe commented 4 years ago

@pozil I've updated the PR and it is ready for review. The bar chart works on my end.

annyhe commented 4 years ago

@pozil Please elaborate on running the lint locally. The lint is run precommit, correct? Which local files are you seeing in this PR that don't belong here? Also running 'npm run lint' goes into localdevserver first, I propose we change the script to prettier --list-different 'src/main/default/*/.{cls,cmp,component,css,html,js,json,md,page,trigger,yaml,yml}'

pozil commented 4 years ago

Yeah, I think that I got confused at some point about this linting stuff so disregard that. I've added the local dev server to the prettier ignore file.