forcedotcom / salesforcedx-docker

The official Dockerfile for Salesforce DX
BSD 3-Clause "New" or "Revised" License
74 stars 25 forks source link

Add jq to image #8

Closed douglascayers closed 4 years ago

douglascayers commented 5 years ago

Is your feature request related to a problem? Please describe.

I use Docker images in CI/CD pipelines. When scripting commands and reacting to the responses, I use the --json flag and parse the JSON with the jq library.

A nice-to-have would be if the jq library were preloaded on this image so that I don't have to have a separate install step in my CI scripts.

Describe the solution you'd like

The jq library loaded as part of the Dockerfile definition.

Describe alternatives you've considered

My CI scripts explicitly install jq.

apt update && apt -y install jq

Additional context

I first learned to use jq to parse CLI JSON responses by working with Wade Wegner on the Salesforce Buildpack for Heroku

vazexqi commented 5 years ago

The current proposal that we have is that we will have "slim" and "full" tags (exact name to be determined).

The "slim" one will have the baremetals to keep the image small. This should be the default if you were to just do a docker pull.

The "full" one will contain other utilities that are useful like jq, etc. We will rely on feedback on the community on what these are.

Thoughts?

douglascayers commented 5 years ago

Sounds like a great plan to me @vazexqi. I know that puts a bit more burden on you all to manage multiple Docker images, but from the end-user perspective, it gives more options and ability to still reference officially supported images before having to resort to (a) creating our own or (b) managing install steps in our CI scripts.

Thanks :)

praksb commented 4 years ago

@douglascayers This issue is now fixed. Our next release should have two docker images one with -full tag that contains jq and the sfdx CLI and the other one with -slim tag that contains only sfdx CLI.

douglascayers commented 4 years ago

Thanks @praksb