Some SLDS tokens suggested by the extension are Salesforce internal

forcedotcom / salesforcedx-vscode-slds

BSD 3-Clause "New" or "Revised" License

27 stars 11 forks source link

Some SLDS tokens suggested by the extension are Salesforce internal #102

Open albarivas opened 2 years ago

albarivas commented 2 years ago

Summary

Some SLDS tokens suggested by the extension are Salesforce internal. Eg: --lwc-varFontSize9 and --lwc-fontWeightLight

Steps To Reproduce:

Create a CSS file like this: .days { font-size: 28px; font-weight: 300; }

Expected result

Validator shows no errors.

Actual result

Validator shows two errors, suggesting to use --lwc-varFontSize9 and --lwc-fontWeightLight tokens, but those are internal.

Additional information

Feel free to attach a screenshot.

VS Code Version:

SFDX CLI Version:

OS and version:

albarivas commented 2 years ago

Same issue with --lwc-spacingNone

albarivas commented 2 years ago

Same issue with --lwc-fontSize5

albarivas commented 2 years ago

@billyma I've also found a GA token that SLDS validator recommends to use, which you can deploy (so must be GA) but that is undocumented --> --lwc-borderWidthThin

Can you take a look at that too? Thanks!

pozil commented 2 years ago

Not sure whether this is the same bug but there's indeed an issue on some tokens. As @albarivas mentioned, some of the validator recommendations like the use of --lwc-fontSize5 cannot be applied. There's autocompletion in VS Code with those tokens but the deploy will fail as you can see in this screenshot: