search

forcedotcom / salesforcedx-vscode

Salesforce Extensions for VS Code
https://developer.salesforce.com/tools/vscode
BSD 3-Clause "New" or "Revised" License
939 stars 397 forks source link

chore: point to the right apex-pmd in Open VSX #5639

Closed mingxuanzhangsfdx closed 2 weeks ago

mingxuanzhangsfdx commented 3 weeks ago

What does this PR do?

apex-pmd has different publishers in VS Code Marketplace and Open VSX Registry. Code Builder installs the extensions from Open VSX, so apex-pmd is not able to be installed in Code Builder. The entry for Open VSX is added. By adding the entry, installing from VS Code marketplace is not affected and no errors can be detected. There is also no error to install apex-pmd from Open VSX with the existence of the entry for Marketplace confirmed by CB team.

What issues does this PR fix or reference?

@W-15936982@

Functionality Before

apex-pmd is not installed from Open VSX.

Functionality After

apex-pmd is installed from Open VSX

diyer commented 3 weeks ago

@mingxuanzhangsfdx curious to know how was this tested n Vs Code without publishing the pack

diyer commented 2 weeks ago

I think this is a bug open vsx. package.json seems to be the source of truth for creating vsixes. And if the same extension has different publishers in marketplace and open vsix, then how do we specify that in a single package.json