forcedotcom / salesforcedx-vscode

Salesforce Extensions for VS Code
https://developer.salesforce.com/tools/vscode
BSD 3-Clause "New" or "Revised" License
939 stars 397 forks source link

chore: update screenshots folder name to match actions/upload-artifact@v4 #5640

Closed daphne-sfdc closed 3 weeks ago

daphne-sfdc commented 3 weeks ago

What does this PR do?

Fixes the issue where screenshots were not being produced for E2E test failures. The issue is happening as a result of the breaking change in actions/upload-artifact@v4.

What issues does this PR fix or reference?

@W-15960945@

Functionality Before

Only one job in a failing E2E test run produces screenshots; the other jobs produce error messages in the upload artifact step with the error message Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run. https://github.com/forcedotcom/salesforcedx-vscode/actions/runs/9477771277

Functionality After

All jobs in a failing E2E test run produce screenshots, in separate folders for each job. https://github.com/forcedotcom/salesforcedx-vscode/actions/runs/9486595338