search

forcedotcom / sfdx-code-analyzer-vscode

Salesforce Code Analyzer is a unified tool for source code analysis. Run Code Analyzer to scan multiple languages in your code and add diagnostic info to your code that describes the violations.
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

NEW (Extension) @W-16442046@ do not throw error when source is undefined #118

Closed gbockus-sf closed 2 months ago

gbockus-sf commented 2 months ago

Kept seeing an error in VSCode randomly associated with CA extension. Figured I'd take a quick peek to see if I could figure out why.

Root cause here: https://github.com/forcedotcom/sfdx-code-analyzer-vscode/blob/4ed5252d599d00ba8b7ddb103f9ede07550f794a/src/lib/fixer.ts#L27

I can't really explain why TS isn't complaining about the string | undefined mismatch with the isSource method, but this should prevent the error.

I didn't see any tests covering this area, but lemme know if I missed it.