forcedotcom / soql-tooling

SOQL Language Tooling features including the Language Server and Query Builder UI.
BSD 3-Clause "New" or "Revised" License
22 stars 8 forks source link

null should be valid in the "value" of a Filter in the builder when the field is a restricted picklist #241

Open novusphere-cons opened 3 years ago

novusphere-cons commented 3 years ago

Summary

When editing SOQL, the keyword null is a valid value in a where clause, such as "WHERE my_picklist_field__c != null", however the Builder does not allow the keyword to be entered in the "value" section of the form.

Steps To Reproduce:

  1. Start a new query.
  2. Select an object (from), and any number of fields into the result set.
  3. Add a filter on a restricted picklist field, and type the word null in the "Value" input field.

Expected result

The word null should be allowed.

Actual result

The input field is highlighted with a red outline and the help text indicating which values are acceptable for the picklist is shown instead.

Additional information

image

WORKAROUND: It's possible to switch to the regular text editor to edit the query and switch back to the builder. The query will execute and the builder will correctly show the value.

image

VS Code Version: 1.55.2

SFDX CLI Version: sfdx-cli/7.91.0-6a6ed69ebe win32-x64 node-v14.15.4

OS and version: Windows 10 Version 20H2 Build 19042.867

smaddox-sf commented 3 years ago

Thank you for trying the SOQL Builder and for the feedback @novusphere-cons ! We will address this gap. (internal tracking ID W-9154711)