search

forceedge01 / behat-fail-aid

Get more out of your test suite by getting it to work with you when tests fail. Works with Goutte and MinkExtension (Selenium2Driver)
MIT License
28 stars 6 forks source link

Remove `date_default_timezone_set()` from FailureContext #77

Closed mpdude closed 3 years ago

mpdude commented 3 years ago

Enabling the FailureContext leads to the default timezone being changed from what was configured previously, thus breaking some of my tests that rely on a particular timezone.

I don't see why changing the timezone is necessary in the first place?

The relevant line seems to be present right from the start, so maybe it was a leftover from early development days? My assumption is that changing such a basic PHP setting in a hard-coded way cannot really be right or intended.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

forceedge01 commented 3 years ago

Can't fault it, thanks @mpdude for raising the PR.

forceedge01 commented 3 years ago

Tag 3.7.2 has been made available. Cheers.

mpdude commented 3 years ago

Wow, amazingly fast. Thank you!

🍻