chadfurman
commented
6 years ago This builds on your other PR, yes?
I won't have time to pull this down and test it for a little while. Would love help with the review...
Open noeliaarcadiaconsulting opened 6 years ago
chadfurman
commented
6 years ago This builds on your other PR, yes?
I won't have time to pull this down and test it for a little while. Would love help with the review...
noeliaarcadiaconsulting
commented
6 years ago The other PR (Oldrelation delete triggers) builds on this one. So, Oldrelation delete triggers PR contains all the changes made. What do you need help with?
chadfurman
commented
6 years ago @noeliaarcadiaconsulting I need someone who isn't the PR author to review this PR and say it looks good.
I also think there might be a need for some tests. Not sure what the state of testing is in this repo
The PR generally looks good, so I'm just after some additional sign-off w.r.t. compilation and general code structure. Someone, preferrably, who knows Java and has read all the code in this PR
jalissonmello
commented
6 years ago Hi, Still need one more to help with tests ? I' am interested to put the changes on main branch
Implementation for support of CONTRAINT option in TRIGGERS: -Modified PATTERN_CREATE_TRIGGER for CONSTRAINT option support for TRIGGER -Modified CreateTriggerParser.java for CONSTRAINT support for TRIGGER with EventTimeQualification expected AFTER and optionaly { NOT DEFERRABLE | [ DEFERRABLE ] { INITIALLY IMMEDIATE | INITIALLY DEFERRED } } -Modified PgTrigger.java for CONSTRAINT options support in sql statement for TRIGGER.