search

fordfrog / apgdiff

Another PostgreSQL Diff Tool
http://www.apgdiff.com
MIT License
355 stars 138 forks source link

Cannot parse string: COMMENT ON COLUMN #260

Open garykuipers opened 5 years ago

garykuipers commented 5 years ago

Apparently, form a comment in August 2018:

Postgres changed the way that search path semantics are used in pg_dump in response to this: https://wiki.postgresql.org/wiki/A_Guide_to_CVE-2018-1058:_Protect_Your_Search_Path

The affect took place earlier this year (March 2018) and affects all supported versions of postgres/pg_dump.

This affects all users of apgdiff, so it would be good to see a fix to address it.

jalissonmello commented 5 years ago

Already exists a PR with the fix. #257

garykuipers commented 5 years ago

Hi there:

Please forgive my ignorance: The fix is from 26 May 2019 but the error I am reporting is from what appears to be the latest release (2.4). WHat am I missing? [image: image.png]

On Mon, Sep 23, 2019 at 4:38 PM jalissonmello notifications@github.com wrote:

Already exists a PR with the fix. #257 https://github.com/fordfrog/apgdiff/pull/257

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fordfrog/apgdiff/issues/260?email_source=notifications&email_token=AEVW4EMMVGBWCNHPJQYWSCTQLFHPVA5CNFSM4IZTCP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7MSWHY#issuecomment-534326047, or mute the thread https://github.com/notifications/unsubscribe-auth/AEVW4ENHYLXJBFBAIKGB3ODQLFHPVANCNFSM4IZTCP6A .

-- Gary Kuipers, President, Casinfo cell +1 805 443 9446 other +1 702 608 6558

jalissonmello commented 5 years ago

The possible fix it's waiting for maintainers review and need to be merged in the main branch. I you want to test, need to compile yourself the project and include the fix

garykuipers commented 5 years ago

thank you

On Tue, Sep 24, 2019 at 5:20 PM jalissonmello notifications@github.com wrote:

The possible fix it's waiting for maintainers review and need to be merged in the main branch. I you want to test, need to compile yourself the project and include the fix

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fordfrog/apgdiff/issues/260?email_source=notifications&email_token=AEVW4EMBO4QMDLIGDV3EIL3QLKVDHA5CNFSM4IZTCP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7QF2AI#issuecomment-534797569, or mute the thread https://github.com/notifications/unsubscribe-auth/AEVW4EP6S2KUUDUOL4P2ISDQLKVDHANCNFSM4IZTCP6A .

-- Gary Kuipers, President, Casinfo cell +1 805 443 9446 other +1 702 608 6558

d1maxa commented 5 years ago

I fixed one more error during parsing comments yesterday, you can try my fork version

garykuipers commented 5 years ago

thank you, will try

On Fri, Oct 25, 2019 at 2:14 AM d1maxa notifications@github.com wrote:

I fixed one more error during parsing comments yesterday, you can try my fork version

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fordfrog/apgdiff/issues/260?email_source=notifications&email_token=AEVW4EJIIMECZW2LONB6J5TQQK2GFA5CNFSM4IZTCP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECHXT7Y#issuecomment-546273791, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEVW4EMLPOTEDVE6WMQNCNTQQK2GFANCNFSM4IZTCP6A .

-- Gary Kuipers, President, Casinfo cell +1 805 443 9446 other +1 702 608 6558