Variable naming - Githubissues

fordkuppp / vending

0 stars 0 forks source link

Variable naming #2

Open JackKrubb opened 1 year ago

JackKrubb commented 1 year ago

https://github.com/fordkuppp/vending/blob/f75a15931efb8d59312574430e38286e9de15672/vending/models.py#L23

Consider naming your attributes more clear to improve on readability
Example: product_name, product_quantity, product_price etc.

fordkuppp commented 1 year ago

In my opinion, naming it this way is better in this case as the variable is under a class. When it's being used it has to be called like this: Machine.id, otherwise it'll be like Machine.machine_id which I think it's too verbose.