search

fordth / jinqJs

jinqJs provides a simple way to perform SQL like queries on javaScript arrays, collections and web services using LINQ expressions.
Other
93 stars 29 forks source link

Add compare method support to .in() and .fullJoin() #30

Closed kirkchris closed 6 years ago

kirkchris commented 6 years ago

Currently .fullJoin and .in only support matching with string fields. This enables support using the comparison functions similar to .join and .leftJoin

Happy to make any changes as needed! But hadn't seen much development here, so wanted to open the PR and see if anyone is around / open to taking in new changes 🙃

fordth commented 6 years ago

Thanks Chris! I committed your changes. Yes I haven't updated it in a while as you can see, but if you have more changes let me know. Thank you!

On Wed, Mar 14, 2018 at 5:46 PM, Chris Kirk notifications@github.com wrote:

Currently .fullJoin and .in only support matching with string fields. This enables support using the comparison functions similar to .join and . leftJoin

Happy to make any changes as needed! But hadn't seen much development here, so wanted to open the PR and see if anyone is around / open to taking in new changes 🙃

You can view, comment on, or merge this pull request online at:

https://github.com/fordth/jinqJs/pull/30 Commit Summary

  • Supporting compare functions in .in() to enable full joins to use compare functions.
  • added comment about jinqjs additions.
  • Cleaning up code to support .in() regular comparisons.
  • reordered comment.
  • bugfix.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fordth/jinqJs/pull/30, or mute the thread https://github.com/notifications/unsubscribe-auth/AJoGABlVC-lK-U9AREuGZU1Rj8OomfLMks5teY--gaJpZM4SrOgc .

kirkchris commented 6 years ago

Thanks a ton, @fordth ! How would you feel about tagging a v1.6.2 so we can use this locked version w/ yarn/npm?

fordth commented 6 years ago

All set!

On Wed, Mar 14, 2018 at 8:37 PM, Chris Kirk notifications@github.com wrote:

Thanks a ton, @fordth https://github.com/fordth ! How would you feel about tagging a v1.6.2 so we can use this locked version w/ yarn/npm?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fordth/jinqJs/pull/30#issuecomment-373221259, or mute the thread https://github.com/notifications/unsubscribe-auth/AJoGANWUyMuPXf9X8XsaKfC51glQkzGUks5tebewgaJpZM4SrOgc .