forem / DEV-ios

DEV Community iOS App
GNU General Public License v3.0
359 stars 97 forks source link

iPad Support #100

Closed pbnj closed 5 years ago

pbnj commented 5 years ago

Describe the bug The app doesn't seem to be optimized for iPad (at least the 11" model for me)

To Reproduce

  1. Rotate iPad to landscape mode
  2. Launch the app.

Expected behavior The app should rotate to landscape mode and scale to the full resolution of the screen.

Screenshots img_0007

Device Info (please complete the following information):

pbnj commented 5 years ago

Worth noting, workaround is to use the web app.

benhalpern commented 5 years ago

Yes. Forewent iPad on initial release to have less to think about. Our overall traffic on iPhone vs iPad is pretty low so it seemed fine, though this is certainly a strong minority to support given the site is about reading.

There isn't much to supporting iPad in a basic at this point besides getting the constraints to line up. I know @Gary-Ash is heavily in favor of this as well.

Happy to accept PRs that do the basic stuff. 🙂

thesohelshaikh commented 5 years ago

iPads are great for reading and it would be great if there were direct support. I like to stay away from my phone to avoid distractions while reading.

I’ll be waiting for this one!

StriderHND commented 5 years ago

I'll take a look into this @benhalpern

StriderHND commented 5 years ago

Hello I've been doing some tests for the iPad support for the dev App.

Here are some screenshoots img_36135b069631-1

img_36f886530e1b-1

I need to do some testing but I don't feel very fluid the transition of orientation of the web view so I'll look how improve this.

StriderHND commented 5 years ago

@benhalpern @maestromac please close this issue.

maestromac commented 5 years ago

👌

Resolved with #112