forem / DEV-ios

DEV Community iOS App
GNU General Public License v3.0
359 stars 97 forks source link

Feature/iPad support #112

Closed StriderHND closed 5 years ago

StriderHND commented 5 years ago

In this PR we add support to iPad devices as requested in the issue #100

Updating the project and doing some small refectory how the URL are loaded I created an extension to WKWebView creating a function called load in this version of load we send a string of the URL we need to load, creates a URL object and a URLRequest with that we assure that we do optional unwrapping of the string we need to load and update the wkwebview. with that now we can load URL string in the following way

webView.load("url_string-to_load")and not do all the optional boilerplate code to unwrap or request.

Storyboard Updates.

If there is any questions please let me know

Erick

chickdan commented 5 years ago

Great update, this looks so much better on iPad!

For future reference, and this applies to any project, it's best to keep unrelated changes as separate PRs just in case something doesn't work, a maintainer doesn't want certain changes, etc.

benhalpern commented 5 years ago

This is great, will get to it soon.

StriderHND commented 5 years ago

Great update, this looks so much better on iPad!

For future reference, and this applies to any project, it's best to keep unrelated changes as separate PRs just in case something doesn't work, a maintainer doesn't want certain changes, etc.

Sure I'll keep that in mind, thanks! @chickdan

StriderHND commented 5 years ago

@benhalpern let me check this one right now.

StriderHND commented 5 years ago

@benhalpern changes are made as requested all looks good across all iOS devices. please check.