Add Native Refresh Button To Navigation Bar

forem / DEV-ios

DEV Community iOS App

GNU General Public License v3.0

359 stars 97 forks source link

Add Native Refresh Button To Navigation Bar #166

Closed vuinguyen closed 4 years ago

vuinguyen commented 5 years ago

This PR address issue https://github.com/thepracticaldev/DEV-ios/issues/164 where the only way to refresh the current page is to do a pull-refresh.

We are giving users an additional way to refresh the page by adding a native refresh button to the navigation bar as shown here: Simulator Screen Shot - iPhone 8 Plus - 2019-08-21 at 16 46 46

I only tested this feature manually, but if you have any feedback on whether or how I should add a unit test or UI test, I welcome that. Thanks!

CLAassistant commented 5 years ago

All committers have signed the CLA.

vuinguyen commented 5 years ago

@benhalpern Just checking in! :) It looks like my PR needs to be reviewed. What questions or feedback do you have on my PR, or does someone else need to review it or ... ?

vuinguyen commented 4 years ago

No worries, @benhalpern ! Glad I could help, and let me know if you have any more questions for me.