Push Notifications fix, deep linking fix and GH Actions CI fix - Githubissues

forem / DEV-ios

DEV Community iOS App

GNU General Public License v3.0

357 stars 97 forks source link

Push Notifications fix, deep linking fix and GH Actions CI fix #237

Closed fdocr closed 3 years ago

fdocr commented 3 years ago

What type of PR is this? (check all applicable)

[x] Refactor
[ ] Feature
[x] Bug Fix
[ ] Documentation Update

Description

Things fixed/covered in this PR:

In the most recent refactor I missed the Push Notifications interest registration
I missed the updateWebView NotificationCenter observer registration which broke deep linking into the app too
- The refactor had removed a custom extension of Notification.Name because it wasn't used. This brings it back with the one notification we are currently using
Adds GitHub Actions in preparation to standardize CI there in favor of Travis

Added to documentation?

[ ] docs.dev.to
[ ] readme
[x] no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

fixing a bike