forem / DEV-ios

DEV Community iOS App
GNU General Public License v3.0
357 stars 97 forks source link

Add cover image bug on Dev-ios / ForemWebView-iOS local build #243

Open leewynne opened 3 years ago

leewynne commented 3 years ago

Describe the bug

When building locally and using testflight, the Dev-ios app crashes when adding a cover image with the error below.

fatalError(“unable to find bundle named YPImagePicker_YPImagePicker”)

To Reproduce

Clone DEV-iOS Run ./carthage.sh update --no-use-binaries --platform iOS --cache-builds Let it fail on the time out Open ForemWebView from the Checkouts folder in XCode Let it resolve the dependencies on its own successfully Run CMD+b to build Let it build successfully then quit Xcode Run ./carthage.sh update --no-use-binaries --platform iOS --cache-builds again Open up the project fully in XCode and run in a simulator to test Expected behavior

Image uploads without error and the cover image is then displayed

Smartphone (please complete the following information):

Device: Iphone 10, 11 & 12 OS, version: iOS 14 and any iOS build on simulator Additional context

This isn't an issue with the production app, it is something that I can consistently replicate when attempting to build locally and submitting to the apps store. The error occurs with a clean xcode installation and fresh repo pull.

fdocr commented 3 years ago

Thanks a lot for helping document this problem here @leewynne!

Implementing #241 (migrate to SPM) would sort out this issue. Anyone willing to take on that issue is very welcome to send in a PR (a great tutorial is available in that issue's description). Otherwise I'll work in fix for that one (and this issue for that matter) as soon as it gets prioritized internally.