search

forem / ForemWebView-ios

Forem core interface SDK
GNU General Public License v3.0
22 stars 7 forks source link

Photos uploaded sideways #16

Closed benhalpern closed 3 years ago

benhalpern commented 3 years ago

Describe the bug When I select a photo to upload, it appears normal in the selection process, but always winds out turned 90% (top is left-facing).. To Reproduce Steps to reproduce the behavior:

  1. Go to "write a post"
  2. Click on "Upload cover image"

Wait to see it upload and note that it is sideways.

fdocr commented 3 years ago

I'm pretty sure the moment the iOS camera takes the picture there's an orientation check we can make to display/store images properly. If #17 goes ahead with a native bridge implementation we can handle this natively.

If that's not the case (no native bridge implementation) it may not be a problem, I think/hope we can still tap in either the JavaScript context (see this example gist) or when the image is processed in the backend. The backend option is not ideal because the processing load would be better off handled on each client.

benhalpern commented 3 years ago

Yeah, I'd favor native bridge in general 👍