Forem.team icon missing

joshpuetz commented 3 years ago

Describe the bug

The favicon Forem.team isn't displaying in the sidebar (previously it was!) on both Safari and Chrome versions of the plugin.

Screenshots

CleanShot 2021-05-20 at 09 35 10@2x

Additional context

The browser favicon for Forem.team has always been...weird!

cmgorton commented 3 years ago

The icon in the browser extension looks even worse on Chrome. The alt text covers up other icons. Screen Shot 2021-05-20 at 10 30 31 AM

fdocr commented 3 years ago

Hi everyone. I wanted to share some ideas/context on this problem:

I think the logo gets fetched here (from Forem instance's meta tags here)
Every instance exposes this metadata (based on the instance's configs) and the iOS app also relies on these 🙂
Maybe the SiteConfig.logo_png changed?
- @joshpuetz @cmgorton could you share the broken URL you're getting? It's working for me with this URL:
  - https://forem.team/images/MzAeH5qmkdd5XFGwz8mecg1ewUmlTxanJPk1Yfs1cFI/w:512/q:80/mb:500000/aHR0cHM6Ly9mb3Jl/bS50ZWFtL2ltYWdl/cy9uT0JlRXpjU0J2/OFJZa0QzYV9YNlZa/b0lkOFkzaWRwLXpQ/N1ZOUzNydUJNL3c6/ODgwL21iOjUwMDAw/MC9hSFIwY0hNNkx5/OW1iM0psL2JTNTBa/V0Z0TDNKbGJXOTAv/WldsdFlXZGxjeTlw/TDNCbS9PWEk0WldO/MGRqQnRZbUpoL05I/TjNkWFV3TG5CdVp3
- If that's the case then this is possibly a bug in the extension logic itself. The extension should handle the situation where the instance's metadata changes and update accordingly

forem / forem-browser-extension