forem / forem

For empowering community 🌱
https://forem.com
GNU Affero General Public License v3.0
21.92k stars 4.03k forks source link

Incorrect interledger payment pointer added to my post #18757

Closed devcer closed 2 months ago

devcer commented 1 year ago

Describe the bug

I have webmonetized my dev.to profile by adding a payment pointer to my profile. Thanks for building the feature. I have started receiving tips for my content as well. However I see I did not receive any micropayments from the past 5 days.

I have tipped myself using Coil to validate this and I did not receive the payment. I went through the code through View Source and I found that an incorrect payment pointer is being added to my post.

My profile is configured with payment pointer $ilp.uphold.com/wypi4eKYYYJw but I see the pointer $ilp.uphold.com/24HhrUGG7ekn being shown in the page.

People have been tipping in front of me but I failed to receive any payments. Can you please check and let me know what went wrong here?

To Reproduce

  1. Go to 'https://dev.to/devcer/10-must-read-guides-for-open-payments-and-web-monetization-enthusiasts-c5a'
  2. Right click and select View page source
  3. Do cmd+f and search for monetization
  4. Observe the payment pointer

Expected behavior

My profile is configured with payment pointer $ilp.uphold.com/wypi4eKYYYJw but I see the pointer $ilp.uphold.com/24HhrUGG7ekn being shown in the page.

Screenshots

Screenshot 2022-11-13 at 15 39 33 Screenshot 2022-11-13 at 15 40 58

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

github-actions[bot] commented 1 year ago

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem-team. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

fdocr commented 1 year ago

Thank you for the report @devcer. I can tell we have logic in place to update the payment pointer on your post. If I lookup your link I can see it there:

Screen Shot 2022-11-28 at 11 16 15

However, that other link you mention is also available within the page

Screen Shot 2022-11-28 at 11 17 00

If you take a closer look you can tell that the second one is only visible within an iframe. That iframe is there as part of the moderation panel. I wonder if this is the reason your payments haven't gone through, if by mistake the tips are going to that other link.

I believe this can be fixed by ensuring the iframe doesn't include the other payment pointer. This can be done in various ways but worth the effort IMO

devcer commented 1 year ago

Thank you @fdocr for checking this. Also, Let me try to do a payment myself and see if I receive the payment. it didn't go through last time. I didn't know that a pointer inside an iframe can receive payments as well.

fdocr commented 1 year ago

Yes, that would be great if you can test that payments work with your pointer @devcer. Our implementation hasn't changed for some time now and I'm not well versed on the tools used for how to test this (either in production/sandbox environments).

I didn't know that a pointer inside an iframe can receive payments as well.

That's just a hypothesis from my end. I can assure you the correct pointer you shared ($ilp.uphold.com/wypi4eKYYYJw) is available in the meta tag of the site.

The reason you don't see it when doing a "view page source" (after a right click on the page) is that post author pointers are loaded with javascript when the page loads, when "viewing page source" directly javascript doesn't execute. If you open the developer tools and inspect the page elements you'll find the correct payment pointer loaded for your article.

Screen Shot 2022-11-29 at 09 04 38