forem / forem

For empowering community 🌱
https://forem.com
GNU Affero General Public License v3.0
21.99k stars 4.05k forks source link

Add Cloudflare as an option for Images::Optimizer #19573

Closed benhalpern closed 1 year ago

benhalpern commented 1 year ago

Is this feature related to a problem? Please describe.

We currently offer two options for image auto-cropping, optimization, and CDN caching: Cloudinary and Imgproxy.

Cloudinary is the cloud option and Imgproxy is the variation which can be containerized as part of the Forem's stack.

Adding Cloudflare Image Resizing service would be a good additional option because:

We could consider migration to Cloudflare for DEV, but would not want to do that hastily. Adding Cloudflare as an option in the Forem stack could provide some experimentation which would better inform a possible migration in the future.

Describe the solution you’d like

Add Cloudflare as a third option to Images::Optimizer, which is turned on with the proper environment variable.

We should not seek to turn this on for DEV any time soon. This is strictly enabling a different option between Cloudinary and Imgproxy. This could inform a proof of concept for a possible DEV migration.

Definition of Done

github-actions[bot] commented 1 year ago

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

To our amazing contributors: issues labeled bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

If this is a feature request from an external contributor (not core team at Forem), please close the issue and re-post via GitHub Discussions.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem-team. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.