search

forem / forem

For empowering community 🌱
https://forem.com
GNU Affero General Public License v3.0
21.9k stars 4.02k forks source link

"Auth with Twitter/GitHub" options not working #770

Closed chrisvasqm closed 5 years ago

chrisvasqm commented 5 years ago

Bug Report

After signing out from my account, I haven't being able to log back in.

Current Behavior

If I use "Auth with GitHub", the page starts to load but nothing happens and I'm not redirected to any other site.

If I use "Auth with Twitter", I get redirected to Twitter's page to quickly be redirected back to dev.to, but I just get this "blank" screen where the main content of the page should be displayed.

Expected Behavior

Should be able to log back in with either Twitter or GitHub (I believe I used GitHub when I first made my account).

Mobile & Desktop Screenshots/Recordings

Using "Auth with Twitter":

devto_blank_twitter

Additional Info (device/browser, helpful links)

Device Operating System Browser
Macbook Pro 2017 13" macOS Mojave 10.14 Chrome, Firefox and Safari
Google Pixel XL Android 9.0 Chrome
math2001 commented 5 years ago

I'm completely new, so just taking a shot in the dark:

  1. Are there any error messages in the console?
  2. Have you tried logging in private mode? Maybe in the process of trying, a weird cookie's just causing the whole thing to fail...
chrisvasqm commented 5 years ago

Hey @math2001, thanks for the tips.

When I try to use GitHub login nothing shows up on the DevTools console and when I use Twitter I get this:

twitter_console_log

I also tried clearing all my browsers cache and cookies, and it keeps acting the same way.

rhymes commented 5 years ago

@chrisvasqm it looks like you have some extension breaking the login. Try to disable ad blockers or extensions like privay badger

jonathan-irvin commented 5 years ago

I'm having the same issues.

Browser Firefox v62.0.2 Build ID 20180920131237 User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:62.0) Gecko/20100101 Firefox/62.0 OS Mac OS X 10.14

jonathan-irvin commented 5 years ago

Having tried this myself:

Are there any error messages in the console?

None. Have you tried logging in private mode? Maybe in the process of trying, a weird cookie's just causing the whole thing to fail... Yes, same issue.

Zhao-Andy commented 5 years ago

This sounds silly but I wonder if this is a Mojave issue. @maestromac want to confirm?

chrisvasqm commented 5 years ago

@chrisvasqm it looks like you have some extension breaking the login. Try to disable ad blockers or extensions like privay badger

Tried disabling, uninstalling and even using a fresh installation of my Firefox browser. Also, I've tried using my phone and I still have the same issues.

jonathan-irvin commented 5 years ago

@Zhao-Andy Logging in from my phone Samsung Galaxy S9+ running Android 8.0.0 is working, but yeah I'd isolate it to Mohave. I experience the same effect on my iMac at home also running Mohave.

jonathan-irvin commented 5 years ago

@chrisvasqm it looks like you have some extension breaking the login. Try to disable ad blockers or extensions like privay badger

Tried disabling, uninstalling and even using a fresh installation of my Firefox browser. Also, I've tried using my phone and I still have the same issues.

What phone are you using?

chrisvasqm commented 5 years ago

In case this might help, I even tried revoking my Twitter and GitHub auth access and trying to log in again, but it didn't help.

chrisvasqm commented 5 years ago

@chrisvasqm it looks like you have some extension breaking the login. Try to disable ad blockers or extensions like privay badger

Tried disabling, uninstalling and even using a fresh installation of my Firefox browser. Also, I've tried using my phone and I still have the same issues.

What phone are you using?

Google Pixel XL with Android 9.0 using the Chrome v69.0.3497.100.

jonathan-irvin commented 5 years ago

@Zhao-Andy Logging in from my phone Samsung Galaxy S9+ running Android 8.0.0 is working, but yeah I'd isolate it to Mohave. I experience the same effect on my iMac at home also running Mohave.

I'm changing my answer here. My phone doesn't work either, but the app does.

Zhao-Andy commented 5 years ago

Hmm @chrisvasqm @jonathan-irvin try now. We recently added in some new authentication logic to prevent duplicate accounts, but there might be some unintended side effects. I believe the issue is that your accounts had some invalid columns.

@jonathan-irvin for your account, you had an invalid LinkedIn URL. I updated it to be blank, so you can add yours again if you'd like.

@chrisvasqm for your account, you had an invalid LinkedIn URL and Stack Overflow URL. I also updated both of them to be blank; feel free to add it again.

Both of those were invalid because we added some stricter formatting for them. Since they were invalid, (I think) this cause our new authentication path to failed.

chrisvasqm commented 5 years ago

Thanks @Zhao-Andy !

All good now, checked on my laptop and phone, with both Twitter and GitHub methods and it's all good now 👏🏻

jonathan-irvin commented 5 years ago

yay, it works!!

Zhao-Andy commented 5 years ago

Hey @chrisvasqm @jonathan-irvin, did you two ever run into the 500 error page when you signed in, or was it always a blank dev.to page?

jonathan-irvin commented 5 years ago

It was blank for me.

chrisvasqm commented 5 years ago

Hey @chrisvasqm @jonathan-irvin, did you two ever run into the 500 error page when you signed in, or was it always a blank dev.to page?

@Zhao-Andy only blank with Twitter and nothing would happen choosing GitHub. No 500 errors for me.