forem / selfhost

Selfhost your Forem Community on your own infrastructure 🎉
https://www.forem.com/get-started/
GNU Affero General Public License v3.0
1.44k stars 172 forks source link

GIFs are broken in Forem Cloud/Self-Host #26

Closed akhil-naidu closed 3 years ago

akhil-naidu commented 3 years ago

Check out this post in forem.dev for more information. You can clearly identify that the cover image is not being displayed. Even though the GIF can be seen in the draft.

All the links => Uploaded GIF URL, Resized URL, CoverImage as GIF and Embedded GIF can be seen in the post.

Probable reason

Within imgproxy there is some issue, because I can view the image in the draft and the preview screen. This tell me that there is no problems with uploading and cropping, so it should be related to fetching.

Another reason; Why I think it is related to imgproxy.

Leeawrdslope is a Forem based community, but not using the traditional self-hosting guide. It is based on dokku and doesn't use imgproxy; for image caching and resizing we are using Cloudinaries Immaga Plugin.

Here is a post on Leewardslope, which holds a GIF as cover

cmgorton commented 3 years ago

Gifs as cover images currently work on DEV. It also works on forem.dev. You can see this draft post here

Possibly the particular gif you are using is not working? One of our engineers mentioned: "looks like they're using Cloudinary on their own Forem whereas forem.dev uses imageproxy. So Cloudinary optimized gif and kept it as a gif, where as imageproxy optimized the gif but broke it in the process" Perhaps the gif you were using is too large for imageproxy?

akhil-naidu commented 3 years ago

Gotcha, this issue was resolved and is also related to few specific GIFs

  1. Large Size GIF
  2. and with some portrait GIFs