search

forensic-architecture / timemap

Exploration, monitoring and classification of incidents in time and space.
Other
348 stars 58 forks source link

Update react-redux dependency #239

Closed wattroll closed 2 years ago

wattroll commented 2 years ago

Now that react was updated to 18 (#233), it would make sense to also update react-redux to 7.

It seems to work OK when I bump it, but I am not very familiar with this codebase and haven't been using react-redux before, so I don't have a good intuition of what needs to be payed attention to when jumping a few major versions. It would be safer if somebody who does could have a look at this.

Just bringing this up, because of a need for useSelector here. Thanks.

breezykermo commented 2 years ago

Yes, we should update this. Would you be interested in opening a PR to do so?

jstolwijk commented 2 years ago

I can pick this one up if no objections ;)

breezykermo commented 2 years ago

Sounds good to me, thanks @jstolwijk!

wattroll commented 2 years ago

@jstolwijk Thanks a lot!