search

forest0xia / dota2bot-OpenHyperAI

A beta Dota2 Bot Script aims to provide better bot game experience
https://steamcommunity.com/sharedfiles/filedetails/?id=3246316298
MIT License
53 stars 11 forks source link

feat: add HeroName enum #23

Closed ThirVondukr closed 2 months ago

forest0xia commented 2 months ago

Lone bear is also a hero unit. Search the code in lua for its full name

forest0xia commented 2 months ago

Think the Ringmaser is also not yet included.

forest0xia commented 2 months ago

Valve official site has been out dated for so long. lmao.

ThirVondukr commented 2 months ago

Lone bear is also a hero unit. Search the code in lua for its full name

I thought we'd use this enum in matchups for example, lone bear isn't a hero you can pick 😅

forest0xia commented 2 months ago

We'd use this whenever we see convenient later since we call it as generic as HeroName not HeroNameForMatchup. This is always how legacy code in projects grow like. So if not now, we will need to add it soon if we want to get the most of this enums as we migrate more features to ts

forest0xia commented 2 months ago

On a second thought, it's probably better to put bear name in some kind of UnitName enum since most people won't think it's a hero by default.