search

forestgeo / fgeo.tool

[R-package on CRAN] General purpose tools for ForestGEO Packages
https://forestgeo.github.io/fgeo.tool
Other
2 stars 6 forks source link

Address CRAN issues #200

Closed maurolepore closed 1 year ago

maurolepore commented 1 year ago

This responds to the following email:

--------- Forwarded message ---------
From: Kurt Hornik <hornik@xmbombadil.wu.ac.at>
Date: Fri, Aug 19, 2022 at 9:11 AM
Subject: CRAN package fgeo.plot
To: <maurolepore@gmail.com>
Cc: <CRAN@r-project.org>

Dear maintainer,

Please see the problems shown on
<https://cran.r-project.org/web/checks/check_results_fgeo.plot.html>.

In particular, please see the "Found the following HTML validation
problems" NOTEs in the "HTML version of manual" check for at least some
of the r-devel checks results. 

R 4.2.0 switched to use HTML5 for documentation pages.  Now validation
using HTML Tidy finds problems in the HTML generated from your Rd
files. 

To fix, in most cases it suffices to re-generate the Rd files using the
current CRAN version of roxygen2.  To check whether this already fixes
things, or whether additional changes you made fixed the problems (e.g.,
if the problem is from yourself directly generating HTML output), you
can grab HTML Tidy version 5.8.0 binaries from
<https://binaries.html-tidy.org/> and, with FOO.Rd an Rd file for which
problems were found, run

  R CMD Rdconv -t html /path/to/FOO.Rd -o FOO.html
  tidy -qe --drop-empty-elements no FOO.html

(Alternatively, you can use R CMD check --as-cran using a current
version of R-devel.)

Can you please fix as necessary?

Please correct before 2022-09-09 to safely retain your package on CRAN.

Best,
-k
codecov[bot] commented 1 year ago

Codecov Report

Merging #200 (ff83e3b) into master (4f5d800) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head ff83e3b differs from pull request most recent head 117e6c2. Consider uploading reports for the commit 117e6c2 to get more accurate results

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   87.46%   87.46%           
=======================================
  Files          24       24           
  Lines         630      630           
=======================================
  Hits          551      551           
  Misses         79       79
Impacted Files Coverage Δ
R/pick_main_stem.R 96.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.