search

forestgeo / fgeo

[Meta R-package on CRAN] Analyse forest diversity and dynamics
https://forestgeo.github.io/fgeo/.
Other
31 stars 12 forks source link

pick_main_stem changes order of tags, and does so differently for each census #215

Open hmullerlandau opened 4 years ago

hmullerlandau commented 4 years ago

pick_main_stem does not preserve the order of tags within a dataset, and it does not produce a consistent new order for different censuses. Thus, if pick_main_stem is applied to two different stem datasets of the same plot, the resulting "full" census datasets will have rows in different order by tag number. This generates problems if the resulting full data sets are then used with functions that assume rows are in the exact same order in different datasets, as for example assumed by all functions in the old CTFS R package. This means that, for example, calculating species-specific mortality rates using mortality.spp or for any other subset of the data will result in incorrect results. No error or warning messages are generated, however, so this problem could easily be overlooked. This problem was detected when applying pick_main_stem to the first two stem datasets for the Mpala plot.

maurolepore commented 4 years ago

Thanks @hmullerlandau for reporting this bug. I'm not sure if anyone is now employed to maintain fgeo. If so, I hope they can follow up. If not, do you think one or a few people in the ForestGEO community would want to become maintaining this project?

djj4tree commented 1 year ago

This is a major issue and I was just coming here to open the issue. If this package is not being maintained, it should probably be removed from CRAN.

DanielZuleta commented 1 year ago

This is a major issue and I was just coming here to open the issue. If this package is not being maintained, it should probably be removed from CRAN.

Totally agree with Dan! I still receive emails asking questions about the tt_test function and just share the original code.