forestry-labs / Rforestry

https://forestry-labs.github.io/Rforestry/
34 stars 10 forks source link

Include tests for cross-language exact reproducibility #102

Closed edwardwliu closed 1 year ago

edwardwliu commented 1 year ago

Runs check for exact predictions between R and Python packages for the following behaviors:

edwardwliu commented 1 year ago

Ideally in a future PR, we can update the outputs to be single line in a future PR. For now, I'd like to merge these tests and release the new version of the Python package 0.10.0 to PyPI today. Thanks for setting up this infra @petrovicboban .

@theo-s The sklearn check PR is blocked on correctly pickling the model, which is a larger fix that we should try to resolve shortly. It would be helpful to include this in the next update.

theo-s commented 1 year ago

I can take a look at the problem with the pickling of the model, it sounds like this shouldn't be that hard to change, but unfortunately, I am pretty busy during the next two weeks. Will try to work on this sometime, but might take a little longer to get too.