forestry-labs / Rforestry

https://forestry-labs.github.io/Rforestry/
34 stars 10 forks source link

Remove b2 tag from Python versioning #104

Closed edwardwliu closed 1 year ago

edwardwliu commented 1 year ago

Updates PyPI release to include:

theo-s commented 1 year ago

This looks good, merging into master. Do I need to do anything further for the Python release to push to PyPI?

edwardwliu commented 1 year ago

IIUC this should've released to PyPI via this pipeline. @petrovicboban to confirm.

theo-s commented 1 year ago

Thanks! I thought so as well, examining the GIthub actions, it seems like the last step (the upload), was skipped (see here), so not sure if I have to do something else to trigger this.

petrovicboban commented 1 year ago

Merging PRs to master will not trigger release. What it does is pushing tags. So once you merge all PRs you want to master, create appropriate tag (needs to match regex) and push it, and that will create github release, and upload package to pypi. We should match tag with version string in pyproject.toml, but there is no constraint on that yet.

theo-s commented 1 year ago

Thanks for the explanation, this makes sense.