Closed theo-s closed 1 year ago
This has passed my further tests locally, it appears the errors are to do with the build.
Will try to quash these, but it might be worth just merging in the changes to the C++/Python code.
@petrovicboban I have a problem with my build when pushing (I can build and recompile the project easily locally, but it doesn't match the setup when it is run through the pipelines).
It would be great to work out exactly what the difference is, I probably just need to clone master again and set it up. For now, since this fork only contains minor changes to two files (that have large logical implications), would you mind integrating the changes to these two files into master?
The error happens because pipeline can't checkout specific commit of armadillo repo. I'll try to fix it.
current status: ✅
Overall Coverage
Statements Covered Coverage Threshold Status 739 513 69% 60% 🟢 New Files
No new covered files...
Modified Files
File Coverage Status Python/random_forestry/forestry.py 67% 🟢 TOTAL 67% 🟢 **updated for commit:
22d3dcd
@theo-s this is ok now, you just need to resolve some styling issues.
You can use ./style.sh
when in Python
directory.
Thanks! @theo-s Could you run the style checker above and merge in this PR?
Thanks @petrovicboban for fixing this, I'll update the style checks and merge this in when the checks pass
Python saving loading is now working as expected across a number of hyper parameter settings. It may be brittle, so testing further before I make this a full PR.
Fixed name again.