forestry-labs / Rforestry

https://forestry-labs.github.io/Rforestry/
34 stars 9 forks source link

Fix Python Saving + Loading #133

Closed theo-s closed 1 year ago

theo-s commented 1 year ago

Python saving loading is now working as expected across a number of hyper parameter settings. It may be brittle, so testing further before I make this a full PR.

Fixed name again.

theo-s commented 1 year ago

This has passed my further tests locally, it appears the errors are to do with the build.

Will try to quash these, but it might be worth just merging in the changes to the C++/Python code.

theo-s commented 1 year ago

@petrovicboban I have a problem with my build when pushing (I can build and recompile the project easily locally, but it doesn't match the setup when it is run through the pipelines).

It would be great to work out exactly what the difference is, I probably just need to clone master again and set it up. For now, since this fork only contains minor changes to two files (that have large logical implications), would you mind integrating the changes to these two files into master?

petrovicboban commented 1 year ago

The error happens because pipeline can't checkout specific commit of armadillo repo. I'll try to fix it.

github-actions[bot] commented 1 year ago

☂️ Python Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
739 513 69% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
Python/random_forestry/forestry.py 67% 🟢
TOTAL 67% 🟢

**updated for commit: 22d3dcd

petrovicboban commented 1 year ago

@theo-s this is ok now, you just need to resolve some styling issues. You can use ./style.sh when in Python directory.

edwardwliu commented 1 year ago

Thanks! @theo-s Could you run the style checker above and merge in this PR?

theo-s commented 1 year ago

Thanks @petrovicboban for fixing this, I'll update the style checks and merge this in when the checks pass