search

forestry-labs / Rforestry

https://forestry-labs.github.io/Rforestry/
34 stars 10 forks source link

Sid hierarchical shrinkage #136

Closed sidc321 closed 1 year ago

sidc321 commented 1 year ago

Added additional vectors to store prediction weight for all nodes and node counts for all noes

github-actions[bot] commented 1 year ago

:no_good: Ups! This branch name is not following the regex ^[a-z]{2,3}/.* Please delete this PR, rename the branch to <author_initials>/<common_sense_branch_name>, and create new PR.

github-actions[bot] commented 1 year ago

☂️ Python Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
739 513 69% 60% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

**updated for commit: cd4560e

edwardwliu commented 1 year ago

@sidc321 Could you rename your branch per the comment above and create a new PR?

edwardwliu commented 1 year ago

Thanks, overall this looks good to me. Will wait if Theo has thoughts, otherwise let's merge this in first thing next week and kick off the second step of actually applying the new tree info.

For future PRs, let's adhere to the naming convention guidance in the this comment in the PR.