forestry-labs / Rforestry

https://forestry-labs.github.io/Rforestry/
34 stars 11 forks source link

Remove groups_mapping parameter #95

Closed edwardwliu closed 1 year ago

edwardwliu commented 1 year ago

Only uses single Panda series to represent groups and removes groups from initial forest instantiation. Fixes the implementation of groups with reproducibility against the R package. Also resolves tree representation of averaging info.

petrovicboban commented 1 year ago

I would rebase this and set last commit "update styling" as fixup for previous one, so we don't have small style fix commits. @edwardwliu

edwardwliu commented 1 year ago

FYI ended up with odd history, but will keep squashing style checks in mind going forward.

theo-s commented 1 year ago

Sounds good, thanks for removing this