search

forestryio / hugo-theme-novela

Novela, the simplest way to start publishing with Hugo and Forestry.
https://hugo-novela-forestry.netlify.app/
MIT License
360 stars 192 forks source link

Suggestions of small fixes in CSS Style #18

Closed ghost closed 4 years ago

ghost commented 4 years ago

Fix: Boxes overlapping

In file layouts/partials/article/hero.html:

<div class="article-hero-image" id="ArticleImage__Hero">
  <img src="{{ . }}">
</div>

According to css file, image will shrink to width: 100% while ratio is keeped. The ratio of hero images, that come with the theme, is arround 2:1. If user pick an image of ratio, say 1.5:1 or even lower, Image box may overlap with Article Content.

It's ok to fix this by overwritting original 'css' files with user specified ones. But maybe you guys can fix this in the upstream, so this theme can gain more popularities.

Nice theme, great work btw.

ghost commented 4 years ago

Fix: Color Toggling Function

Color pre-setting in css file:

#logo-desktop .change-fill {
    fill: var(--primary);
}

This pre-setting works fine when all the elements inside the logo are solid. But when some logo element is hollow, like alpahbet 'O'. Two paths of opposite filling-color (--primary, --background-color) will be defined in svg. Both are in class chang-fill, of course.

In order to have color toggling functions still well functioning, this pre-set color should be reconsidered.