search

foreversd / forever-monitor

The core monitoring functionality of forever without the CLI
MIT License
1.16k stars 178 forks source link

Upadate chokidar to latest version #165

Closed janwiemers closed 4 years ago

janwiemers commented 5 years ago

This pull request fixes a security vulnerability NODE-SECURITY-786 (https://nodesecurity.io/advisories/786)

The one thing killing me right now is that one test is broken with and without my changes. Can you weight in here?

When using forever-monitor an instance of Monitor with valid options setting hideEnv when spawning all-env-vars.js
    ✗ should hide the environment variables passed to the child
        » expected 1,
    got  0 (==) // macros.js:14

Thanks Jan

kibertoad commented 5 years ago

@janwiemers Thanks! Will take a look.

smhg commented 4 years ago

LGTM! On my machine (Linux) all tests run fine. At least on node <= 11. There is another error in tests on node >= 12, but that has nothing to do with bumping chokidar.

@kibertoad you need some (minor) help maintaining this?

kibertoad commented 4 years ago

-irrelevant-

smhg commented 4 years ago

@kibertoad that's a very reasonable and responsible approach in this scenario. Thank you both for thinking this through and taking the time to provide feedback!

Unrelated and only out of curiosity: why the recent (small) commits to both this and the forever repo?

indexzero commented 4 years ago

forever is not dead. If I've been difficult to reach please accept my apologies – unfortunately I cannot discuss why but one day soon I hope to share what has been taking up the bulk of my time the last few years. It's quite personal and prolonged.

Until then thanks for trying to help here @kibertoad, but again, I assure you – this project is not dead.

kibertoad commented 4 years ago

@smhg So, latest update: we finally had a chat with @indexzero and he handled everything in a super classy way; now active support for forever has restarted, and I would be most happy to accept any and all help that you would be willing to offer; if after a while of contributing to forever you'll still feel comfortable to keep doing so (I must warn you, its codebase is not exactly for the faint of the heart, though 😅 ), you would be most welcome to join ranks of maintainers :)

kibertoad commented 4 years ago

@smhg Any chance you could take a look at https://github.com/foreversd/forever-monitor/issues/177?

kibertoad commented 4 years ago

Released in forever@2.0.0